Skip to content

feat(code): unified PR creation workflow#1377

Draft
adboio wants to merge 1 commit intomainfrom
03-30-feat_code_unified_pr_creation_workflow
Draft

feat(code): unified PR creation workflow#1377
adboio wants to merge 1 commit intomainfrom
03-30-feat_code_unified_pr_creation_workflow

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented Mar 30, 2026

Problem

the current method for getting changes shipped takes a lot of clicks, and at least 3 separate modals -- create branch, commit, create PR.

for what i expect to be the more general case ("agent did work, i wanna ship it"), we can simplify this

removed

  • existing "commit and create PR" flow from the commit dialog
  • existing standalone "create pr" action / dialog

added

introduces a new unified "create PR" workflow that does these steps, as needed:

  1. create & checkout new branch
  2. commit
  3. push
  4. create PR
full input - on default branch, changes to be committed loading states error state
Screenshot 2026-03-31 at 9.27.33 AM.png
Screenshot 2026-03-31 at 9.27.47 AM.png
Screenshot 2026-03-31 at 9.27.52 AM.png

create pr flow notes:

  • if the user is already on a non-default branch, the first step is optional
  • if the user has no uncommitted changes, the flow starts on step 3
  • if a PR already exists on the current branch and there are new uncommited changes, the flow creates a new branch (stack time baby)
  • AI generation is delayed til the user clicks "create" - happens if the commit msg and/or pr details are left empty
  • primary CTA swaps to "view PR" when a PR exists, until new changes appear, then it swaps back to "create PR"
  • all existing individual actions are still available in the dropdown

minor fixes along the way

  • increases codemirror's default diff scan limit to avoid wonky diff rendering
  • adds dupe checking to auto-suggested branch names
  • updates pr title/body generator to pass the whole diff instead of just filenames

How did you test this?

i have not yet tested this in cloud or worktrees

manually tested, i know it's a big PR, so would appreciate others manually testing a bit too 💪

Copy link
Copy Markdown
Contributor Author

adboio commented Mar 30, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch 5 times, most recently from e694de0 to 6950f57 Compare March 31, 2026 00:54
@adboio adboio marked this pull request as ready for review March 31, 2026 00:54
@adboio adboio requested a review from a team March 31, 2026 00:54
@jonathanlab jonathanlab removed the request for review from a team March 31, 2026 07:48
@adboio adboio requested a review from a team March 31, 2026 14:49
@adboio adboio marked this pull request as draft March 31, 2026 14:52
@adboio adboio removed the request for review from a team March 31, 2026 14:53
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch 2 times, most recently from 4018e12 to 06793ef Compare March 31, 2026 16:25
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 06793ef to b86f01b Compare March 31, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant